Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cassandra-stress): bump c-s version to 3.17.0 #9296

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(cassandra-stress): bump c-s version to 3.17.0 #9296

merged 1 commit into from
Nov 26, 2024

Conversation

CodeLieutenant
Copy link
Contributor

@CodeLieutenant CodeLieutenant commented Nov 20, 2024 •
edited
Loading

bump c-s version to 3.17.0

Main reason for version change:

  • Using cassandra-stress 3.17 to mittigate
    Switch to ReplicaOrdering.RANDOM for select LBPs 32

Other Noticable Changes since the last version used in SCT:

  • Add support for hostname verification 31
  • Print thread dump on specific signals 27
  • Replace uninterruptible wait 26
  • Make it use DCAwareRoundRobinPolicy unless rack is provided 21
  • feature(docker): adding support for dependabot 19

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@CodeLieutenant CodeLieutenant self-assigned this Nov 20, 2024
@swasik swasik mentioned this pull request Nov 20, 2024
Closed
2 tasks
vponomaryov
vponomaryov previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch marked this pull request as draft November 20, 2024 12:12
@fruch
Copy link
Contributor

fruch commented Nov 20, 2024

there was an ask, to first test it to see if it elevate any of the issues observed

@swasik
Copy link

swasik commented Nov 20, 2024

there was an ask, to first test it to see if it elevate any of the issues observed

@fruch could you propose owner and the the specific issue?

@fruch
Copy link
Contributor

fruch commented Nov 20, 2024

there was an ask, to first test it to see if it elevate any of the issues observed

@fruch could you propose owner and the the specific issue?

I'm trying it for https://github.com/scylladb/scylla-enterprise/issues/4946

@juliayakovlev would be trying it for https://github.com/scylladb/scylla-enterprise/issues/4504

@juliayakovlev
Copy link
Contributor

there was an ask, to first test it to see if it elevate any of the issues observed

@fruch could you propose owner and the the specific issue?

I'm trying it for scylladb/scylla-enterprise#4946

@juliayakovlev would be trying it for scylladb/scylla-enterprise#4504

Read & mixed test - the issue is reproduced:
https://argus.scylladb.com/tests/scylla-cluster-tests/e7d86441-8c7d-4798-9348-ea8924a2f608
https://argus.scylladb.com/tests/scylla-cluster-tests/99a2a6c4-054b-4abc-b2ab-f91f01dd311f

Write load - it was not happened with previous cassandra-stress version and is not happened with 3.16.0
https://argus.scylladb.com/tests/scylla-cluster-tests/21b0f3be-3306-440c-b4f4-a6a04c8c1e0e

@fruch
Copy link
Contributor

fruch commented Nov 21, 2024

@juliayakovlev

please report those finding in:
https://github.com/scylladb/scylla-enterprise/issues/4504

@fruch
Copy link
Contributor

fruch commented Nov 21, 2024

@CodeLieutenant 3.16.0 doesn't have scylladb/cassandra-stress#32 in it.

can you please release a new c-s version that would include it ?

@CodeLieutenant
Copy link
Contributor Author

@CodeLieutenant 3.16.0 doesn't have scylladb/cassandra-stress#32 in it.

can you please release a new c-s version that would include it ?

Sorry my mistake, I thought it was released with 3.16.
Release 3.17 with be in a few minutes.

@CodeLieutenant CodeLieutenant force-pushed the chore--c-s-version-bump branch from 3c5bc69 to 0c659c7 Compare November 21, 2024 15:32
@CodeLieutenant CodeLieutenant changed the title fix(cassandra-stress): bump c-s version to 3.16.0 fix(cassandra-stress): bump c-s version to 3.17.0 Nov 21, 2024
@CodeLieutenant CodeLieutenant marked this pull request as ready for review November 21, 2024 15:35
vponomaryov
vponomaryov requested changes Nov 21, 2024
View reviewed changes
defaults/test_default.yaml Outdated Show resolved Hide resolved
@CodeLieutenant CodeLieutenant force-pushed the chore--c-s-version-bump branch from 0c659c7 to d96f633 Compare November 21, 2024 15:51
vponomaryov
vponomaryov previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeLieutenant CodeLieutenant force-pushed the chore--c-s-version-bump branch from 060696c to 03c7a2b Compare November 23, 2024 11:22
vponomaryov
vponomaryov approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Contributor

fruch commented Nov 25, 2024

@roydahan

so scylladb/cassandra-stress#32, wasn't fixing any of the issues
but there are multiple other change/fixed in this release we do want to have in SCT

fruch
fruch approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soyacz
Copy link
Contributor

soyacz commented Nov 25, 2024

@roydahan

so scylladb/cassandra-stress#32, wasn't fixing any of the issues but there are multiple other change/fixed in this release we do want to have in SCT

I think this one get's fixed: scylladb/scylladb#19107

@fruch
Copy link
Contributor

fruch commented Nov 25, 2024

@roydahan
so scylladb/cassandra-stress#32, wasn't fixing any of the issues but there are multiple other change/fixed in this release we do want to have in SCT

I think this one get's fixed: scylladb/scylladb#19107

I would guess it wouldn't

did anyone rerun it with this one ?

@soyacz
Copy link
Contributor

soyacz commented Nov 25, 2024

@roydahan
so scylladb/cassandra-stress#32, wasn't fixing any of the issues but there are multiple other change/fixed in this release we do want to have in SCT

I think this one get's fixed: scylladb/scylladb#19107

I would guess it wouldn't

did anyone rerun it with this one ?

see https://github.com/scylladb/scylla-enterprise/issues/4504#issuecomment-2495859043 - results don't show imbalance anymore (just latency and throughput issues for read and mixed scenarios)

@fruch
Copy link
Contributor

fruch commented Nov 25, 2024

@roydahan
so scylladb/cassandra-stress#32, wasn't fixing any of the issues but there are multiple other change/fixed in this release we do want to have in SCT

I think this one get's fixed: scylladb/scylladb#19107

I would guess it wouldn't

did anyone rerun it with this one ?

see https://github.com/scylladb/scylla-enterprise/issues/4504#issuecomment-2495859043 - results don't show imbalance anymore (just latency and throughput issues for read and mixed scenarios)

The issue is about latency, and that run proves that the imbalance is not the cause of latency issues.

I.e. it seems to not be that critical

@roydahan roydahan mentioned this pull request Nov 25, 2024
Closed
2 tasks
@fruch fruch merged commit 02997a6 into scylladb:master Nov 26, 2024
7 checks passed
This was referenced Nov 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@CodeLieutenant CodeLieutenant deleted the chore--c-s-version-bump branch November 26, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swasik swasik swasik approved these changes

@vponomaryov vponomaryov vponomaryov approved these changes

@fruch fruch fruch approved these changes

Assignees

@CodeLieutenant CodeLieutenant

Labels
backport/perf-v15-done backport/perf-v16-done backport/6.0 backport/6.1-done Commit backported to 6.1 backport/6.2-done backport/2024.1 Need backport to 2024.1 backport/2024.2-done Commit backported to 2024.2 promoted-to-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CodeLieutenant @fruch @swasik @juliayakovlev @vponomaryov @soyacz @scylladbbot